Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use files in package.json #292

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use files in package.json #292

wants to merge 1 commit into from

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented May 10, 2015

Reduces amount of files consumer gets when npm installing.

Before: http://hastebin.com/wacequlono.sh
After: http://hastebin.com/karavebiko.sh

I also added phantomjs to devDeps. I expect npm install && npm test to not explode because of missing dependencies 😄

npm install <package> automatically alphabetizes the list

@SimenB
Copy link
Contributor Author

SimenB commented Jul 13, 2015

@chiefGui As you seem to be maintaining this now, could you merge this? I don't need test, documentation, gruntfile or extra copies of libraries (5 backbone, one jquery and one underscore) 😄

@chiefGui
Copy link
Collaborator

Hey @SimenB! Thank you for highlighting up this issue. I just have to patch it right then I'll merge—tested just right now.

@rundef
Copy link

rundef commented Feb 17, 2016

grunt still fails because phantomjs is missing.

backbone-validation-grunt-error

@SimenB
Copy link
Contributor Author

SimenB commented Mar 29, 2016

@chiefGui ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants